add read-only webdav support #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahti
force-pushed
the
webdav
branch
5 times, most recently
from
c6a083c to
6f082ad
Compare
ahti
changed the title
svenstaro
requested changes
Sep 22, 2024
|
Please rebase this! |
ahti
force-pushed
the
webdav
branch
3 times, most recently
from
a533dd3 to
ee763fd
Compare
svenstaro
requested changes
Jan 11, 2025
There was a problem hiding this comment.
I'd like to see you use a real webdav client to check whether this does something useful. I think reqwest_dav would be suitable. Also I'd like to see you handle:
- Single file serving mode (new_file seems to easily handle this)
--route-prefix/--random-route--no-symlinks
This was referenced Jan 14, 2025
ahti
force-pushed
the
webdav
branch
3 times, most recently
from
d0812a1 to
3ab5706
Compare
svenstaro
approved these changes
Feb 6, 2025
Comment on lines
+98
to
+107
| // Make symlinks | ||
| let symlink_directory_str = "symlink_directory"; | ||
| let symlink_directory = server.path().join(symlink_directory_str); | ||
| let symlinked_direcotry = server.path().join(DIRECTORIES[0]); | ||
| symlink_dir(symlinked_direcotry, symlink_directory).unwrap(); | ||
|
|
||
| let symlink_filename_str = "symlink_file"; | ||
| let symlink_filename = server.path().join(symlink_filename_str); | ||
| let symlinked_file = server.path().join(FILES[0]); | ||
| symlink_file(symlinked_file, symlink_filename).unwrap(); |
There was a problem hiding this comment.
Memo to self: Maybe just refactor the integration tests dir fixtures in fixtures/mod.rs to always have symlinks? Would likely allow us to cut a few lines from some tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds read-only webdav support by (when indexing isn't disabled) routing OPTIONS/PROPFIND requests to a
DavHandlerfrom thewebdav-servercrate. Hidden files are excluded via a customDavFileSystem.