[wip] Update actix web to v4.0.0-beta.15 #677
Conversation
src/config.rs
Outdated
| .with_safe_default_protocol_versions() | ||
| .unwrap() | ||
| .with_no_client_auth() | ||
| .with_single_cert(vec!(rustls::Certificate(cert_chain)), rustls::PrivateKey(keys.remove(0)))?; |
There was a problem hiding this comment.
I think I did well with refactoring this code, but please carefully review as I have not too much clue about tls things.
Jikstra
changed the title
Thanks for your initial pr :) |
|
@aliemjay I think in your pr one test failed because of a regression in actix-web. To me it looked like the test was a bit weird anyways? Lot's of special chars if I remember correctly. Probably we can just kick out that test? |
Jikstra
force-pushed
the
update_actix_web
branch
from
a826b20 to
bb3ef44
Compare
I don't think so. It is there for a reason and, if I remember, it fixed a reported issue. Anyway, it is on the plan for v4. |
|
Oh, I forgot to note that most of my PR changes are now merged because I split it into a different PR. You may want to resolve the conflicts, but I think it is cleaner to rebase the last commits. |
Jikstra
force-pushed
the
update_actix_web
branch
from
fc296e4 to
a41d202
Compare
I think I successfully rebased this pr :) |
Jikstra
force-pushed
the
update_actix_web
branch
2 times, most recently
from
303bb0c to
197a331
Compare
Co-authored-by: Ali MJ Al-Nasrawy <alimjalnasrawy@gmail.com>
Jikstra
force-pushed
the
update_actix_web
branch
from
197a331 to
00598ac
Compare
|
Soooo, all looks good now besides this one failing test. @aliemjay could we somehow decode those chars on our own in miniserve or do we need to wait for actix_web to fix this? |
I believe yes. There is nothing we can do in our part. I'll push for it and try to get it soon. |
|
Actix-web beta.19 is now out with a fix to the regression. |
|
Awesome! |
|
Hey, how are we looking on the fix? The actix-web 4 rc is out so now might be a good time to get this merged. |
|
I will not have time to work on this before mid of march, so feel free to just continue this pr whoever wants to :) |
Currently wip/draft as there's some things left to do:
map_error_page()Route / could not be founderror