-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to specify custom flags #2
Conversation
Use @actions/exec instead of child_process
Awesome! I like the usage of |
Perhaps you could also add a new complex example using these args to the end of the README? |
I wonder what's the purpose of
Yes of course |
In my tests, no |
@svenstaro I have just checked, you right! So I think we could add an input to enable/disable |
So far in my tests, strip was always available in GitHub Actions and is working as intendend. |
I talked about final result when a Windows executable is stripped. |
I use this action here and it seems fine. |
Add strip and strip_args input
@svenstaro Ok I have made some changes ;) |
Good changes so far, but I'm still missing the second example for the README with the args in use. |
Seems good to me. Once the README is expanded this seems good to merge. |
@svenstaro I have updated README with a complete example of the available inputs. |
I'd prefer a second example. One for the simple case and one for the complex case. For reference, see https://github.com/svenstaro/upload-release-action |
Done 🙂 |
Great stuff! |
Released as 1.1.0. |
Yeah 🚀 🎉 |
Fixes #1 and also use
@actions/exec
instead ofchild_process
dep