Use keepalives instead of handshakes for timeouts #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomgroenwoldt
force-pushed
the
use-keep-alives-instead-of-handshake-for-timeout
branch
from
38bcb95 to
0fa0b1a
Compare
|
I would like to straighten the altered main loop before merging. The idea of this MR is reviewable though. |
svenstaro
reviewed
May 4, 2023
tomgroenwoldt
force-pushed
the
use-keep-alives-instead-of-handshake-for-timeout
branch
from
0fa0b1a to
f580f1b
Compare
|
I didn't come up with an improvement for the new additions in the main loop. There's still the open question, whether we need a debounce or not, and I'm not sure. |
svenstaro
requested changes
May 5, 2023
| loop { | ||
| if args.peer_timeout > Duration::ZERO && last_timeout_removal.elapsed() > timeout_debounce { |
There was a problem hiding this comment.
It should still be possible to disable timeout entirely by setting the duration to zero. Please put this back in.
tomgroenwoldt
force-pushed
the
use-keep-alives-instead-of-handshake-for-timeout
branch
from
f580f1b to
e4d7522
Compare
|
After the merge of this PR I will rework #11 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the use of keepalives instead of handshakes via wireguard. Handshakes are made approx. every minute, keepalives are configurable. This way we can test a peer deletion without waiting for a handshake. This also allows us to introduce tighter timeout intervals, as the lower bound isn't fixed to one minute anymore.