-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Android Support Library support module #15
base: master
Are you sure you want to change the base?
Conversation
ZimM-LostPolygon
commented
Jan 21, 2018
- Added support for Android Support Library via a separate dependent time-duration-picker-support library
- Minor refactoring.
- Removed .idea folder from the repo. It is not supposed to be under version control.
# Conflicts: # .idea/misc.xml # .idea/modules/sample/sample.iml # .idea/modules/time-duration-picker/time-duration-picker.iml # .idea/modules/timedurationpicker.iml # README.md # sample/build.gradle # time-duration-picker/build.gradle
Many thanks for your PR. Unfortunately I'm currently lacking time to dig into this. I'll come back later. Sorry. |
No problem. Thanks for making this great library. It is the only one that does exactly what I needed, and it works great. |
@svenwiegand any news here? Please note that the platform's native Fragment is deprecated and people are advised to use the support library version. When trying to use your awesome library, I get a Please consider reviewing this MR! @kapalex Due to the above, I think we don't need a dedicated |
@grote I'm not up-to-date with android development anymore. I understood your comment so, that the support-variant from this PR is the only variant we are need, as the other stuff is deprecated. Correct? |
Yes that's correct. You can of course still offer the old variant, if you want. |
…dX is supported now Bumped version to 1.2.0 Updated dependencies
Fixed deprecated method usage
Fixed a few validation warnings
chore: bump Gradle
feat: bump minSDK to 21