Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Android Support Library support module #15

Open
wants to merge 38 commits into
base: master
Choose a base branch
from

Conversation

ZimM-LostPolygon
Copy link

  • Added support for Android Support Library via a separate dependent time-duration-picker-support library
  • Minor refactoring.
  • Removed .idea folder from the repo. It is not supposed to be under version control.

@svenwiegand
Copy link
Owner

Many thanks for your PR. Unfortunately I'm currently lacking time to dig into this. I'll come back later. Sorry.

@ZimM-LostPolygon
Copy link
Author

No problem. Thanks for making this great library. It is the only one that does exactly what I needed, and it works great.

@grote
Copy link

grote commented Aug 8, 2018

@svenwiegand any news here? Please note that the platform's native Fragment is deprecated and people are advised to use the support library version.

When trying to use your awesome library, I get a
ClassCastException: mobi.upod.timedurationpicker.TimeDurationPickerPreference cannot be cast to android.support.v7.preference.Preference. I'm afraid in its current state, it is not really useful anymore to people.

Please consider reviewing this MR!

@kapalex Due to the above, I think we don't need a dedicated -support version anymore.

@svenwiegand
Copy link
Owner

@grote I'm not up-to-date with android development anymore. I understood your comment so, that the support-variant from this PR is the only variant we are need, as the other stuff is deprecated. Correct?

@grote
Copy link

grote commented Nov 3, 2018

Yes that's correct. You can of course still offer the old variant, if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants