Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(report): adds azure-devops reporter #821

Merged
merged 19 commits into from
Jul 9, 2023

Conversation

sverweij
Copy link
Owner

@sverweij sverweij commented Jul 7, 2023

Description

  • adds an azure-devops reporter

TODO

  • documentation
  • on par with the err and teamcity reporters for the summary
  • on par with the err and teamcity reporters for the summary (while using ignored violations)
  • better on par with the err and teamcity reporters for the individual violations

Motivation and Context

fixes #820

How Has This Been Tested?

  • green ci
  • additional automated tests

Screenshots

Current sample output of

npm run depcruise --no-ignore-known -T azure-devops --no-progress

will yield

##vso[task.logissue type=error;sourcepath=src/stout.mjs]not-to-dev-dep: src/stout.mjs -> node_modules/chai/index.js
##vso[task.logissue type=error;sourcepath=src/graph-utl/consolidate-to-folder.mjs]not-unreachable-from-cli: src/graph-utl/consolidate-to-folder.mjs
##vso[task.logissue type=error;sourcepath=src/schema/baseline-violations.schema.mjs]not-unreachable-from-cli: src/schema/baseline-violations.schema.mjs
##vso[task.logissue type=error;sourcepath=src/stout.mjs]not-unreachable-from-cli: src/stout.mjs
##vso[task.logissue type=warning;sourcepath=src/stout.mjs]not-unreachable-from-test: src/stout.mjs
##vso[task.logissue type=warning;sourcepath=src/utl/array-util.mjs]utl-module-not-shared-enough: src/utl/array-util.mjs
##vso[task.logissue type=warning;sourcepath=src/utl/find-all-files.mjs]utl-module-not-shared-enough: src/utl/find-all-files.mjs
##vso[task.logissue type=warning;sourcepath=src/utl/wrap-and-indent.mjs]utl-module-not-shared-enough: src/utl/wrap-and-indent.mjs
##vso[task.complete result=Failed;]8 dependency violations (4 error, 4 warning/ informational). 526 modules, 1311 dependencies cruised

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

@sverweij sverweij force-pushed the feature/adds-azure-devops-reporter branch from f0ede88 to 6b30de0 Compare July 8, 2023 11:58
@sverweij
Copy link
Owner Author

sverweij commented Jul 8, 2023

@jmarek-sky I now notice it's possible to put the rule name in the code field

So instead of doing this:

##vso[task.logissue type=error;sourcepath=src/index.js]not-to-dev-dep src/index.js -> node_modules/eslint/lib/api.js

we can do this:

##vso[task.logissue type=error;sourcepath=src/index.js;code=not-to-dev-dep;]src/index.js -> node_modules/eslint/lib/api.js

... which also seems what eslint-formatter-azure-devops is doing.

I'll make that modification later in the weekend & publish that as dependency-cruiser@13.1.0-beta-3 .

I've added this (see commit 50f05a5) & published the result as dependency-cruiser@13.1.0-beta-3.

@sverweij sverweij marked this pull request as ready for review July 8, 2023 20:34
@sverweij sverweij merged commit fb262fa into main Jul 9, 2023
5 checks passed
@sverweij sverweij deleted the feature/adds-azure-devops-reporter branch July 9, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Formatter for Azure DevOps
2 participants