Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(test): replaces chai with node:assert and chai-json-schema with ajv #823

Merged
merged 28 commits into from
Jul 28, 2023

Conversation

sverweij
Copy link
Owner

@sverweij sverweij commented Jul 25, 2023

Description

  • replaces the chai assertion library use with their native node:assert counterparts
  • replaces the chai-json-schema chai plugin with a straight use of ajv
  • removes chai-json-schema from the manifest as it ain't used no more

The more laborious parts we'll do in a separate PR, likely with the help of a codemod of sorts.

Motivation and Context

  • less dependencies to manage
  • node:assert ships with node anyway and is good enough™️

How Has This Been Tested?

  • green ci

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

@sverweij sverweij changed the title refactor(test): replaces chai with node:assert (& ajv) refactor(test): replaces chai with node:assert and chai-json-schema with ajv Jul 27, 2023
@sverweij sverweij marked this pull request as ready for review July 28, 2023 19:49
@sverweij sverweij merged commit 64398da into main Jul 28, 2023
5 checks passed
@sverweij sverweij deleted the refactor/phase-out-chai branch July 28, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant