Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(report): rewrites err-html reporter without handlebars #829

Merged
merged 3 commits into from
Aug 13, 2023

Conversation

sverweij
Copy link
Owner

@sverweij sverweij commented Aug 13, 2023

Description

  • rewrites the err-html reporter in plain javascript

Motivation and Context

  • reduces the shipped size of dc without added complexity
  • step towards handlebars-less-ness (less dependencies === less worries)

How Has This Been Tested?

  • green ci
  • additional automated tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

@sverweij sverweij changed the title refactor(report): rewrites err-html report implementation without handlebars refactor(report): rewrites err-html reporter without handlebars Aug 13, 2023
@codeclimate
Copy link

codeclimate bot commented Aug 13, 2023

Code Climate has analyzed commit cac5480 and detected 0 issues on this pull request.

View more on Code Climate.

@sverweij sverweij merged commit 30ea30f into main Aug 13, 2023
6 checks passed
@sverweij sverweij deleted the refactor/de-handelbar-err-html-reporter branch August 13, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant