Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(test): sources assertions from assert/strict to ease strict comparisons #834

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

sverweij
Copy link
Owner

@sverweij sverweij commented Aug 23, 2023

Description

  • in stead of using the strictEqual/ deepStrictEqual methods from node:assert use the equal and deepEqual methods from node:assert/strict

Motivation and Context

... which makes tests easier to read.

How Has This Been Tested?

  • green ci

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

@codeclimate
Copy link

codeclimate bot commented Aug 23, 2023

Code Climate has analyzed commit 18f41e6 and detected 0 issues on this pull request.

View more on Code Climate.

@sverweij sverweij merged commit 2344164 into main Aug 23, 2023
6 checks passed
@sverweij sverweij deleted the refactor/to-assert-strict branch August 23, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant