feat(extract): makes support for subpath imports explicit #855
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
aliased-subpath-import
,aliased-webpack
,aliased-tsconfig
moreThanOneDependencyType
rule/ matcher so ...type-only
as separate dependency types (also: see documentation)TODO: subpath imports can resolve to local modules (
"#*": "./src/*"
), but also to 3rd party modules ("#aliasdash/*": "lodash/*"
) or even core modules (which should be considered a criminal offence and is currently not even recognized in enhanced-resolve:"#path-but-aliased": "path"
). These should be added to the dependencyTypes array as well - will probably be in a separate PR, though.Motivation and Context
subpath imports work since node 12.9 (!) and are a vastly superior alternative to tsconfig paths other alias systems (in webpack, babel, ...):
Dependency-cruiser already correctly resolved subpath imports - this PR ensures they're explicitly named as such.
How Has This Been Tested?
Types of changes
Checklist
📖
⚖️