refactor(graph-utl): normalizes name attribute of dependencies on construction to simplify processing

[sverweij]

Description

• normalizes name attribute on construction to simplify processing. Before you had to specify whether you'd use resolved (for regular modules) or name (for folders) when invoking any method that needed these (e.g. getCycle).
• refactors the getCycle attribute a bit so it emits the correct output for self-referencing modules
• makes some methods that were meant to be private really private
• renames some things to be a bit closer to default graph theory nomenclature

How Has This Been Tested?

• green ci

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• Documentation only change
• Refactor (non-breaking change which fixes an issue without changing functionality)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• 📖

  • My change doesn't require a documentation update, or ...
  • it does and I have updated it

• ⚖️

  • The contribution will be subject to The MIT license, and I'm OK with that.
  • The contribution is my own original work.
  • I am ok with the stuff in CONTRIBUTING.md.

[codeclimate]

Code Climate has analyzed commit 658697a and detected 0 issues on this pull request.

View more on Code Climate.