Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resolve): makes dependency classifier handle more flavours of the 'workspaces' type alias field #920

Merged
merged 2 commits into from
Mar 16, 2024

Conversation

sverweij
Copy link
Owner

@sverweij sverweij commented Mar 12, 2024

Description

  • ignores 'workspaces' field when it isn't an array and it doesn't contain a yarn1 workspaces.packages field
  • also classifies dependencies resolving via yarn1 workspaces.packages fields as aliased, aliased-workspace

Motivation and Context

fixes #919

How Has This Been Tested?

  • green ci
  • additional automated non-regression test

Note: a version with this fix has been published as dependency-cruiser@16.2.4-beta-1 - once the PR is merged it'll be part of dependency-cruiser@16.2.4.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

Copy link

codeclimate bot commented Mar 13, 2024

Code Climate has analyzed commit 717ef45 and detected 0 issues on this pull request.

View more on Code Climate.

@sverweij sverweij changed the title fix(resolve): ignores 'workspaces' field when it isn't an array fix(resolve): makes dependency classifier handle more flavours of the 'workspaces' type alias field Mar 16, 2024
@sverweij sverweij merged commit 1c2920e into main Mar 16, 2024
11 checks passed
@sverweij sverweij deleted the bugfix/check-workspaces-array-i-ness branch March 16, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue: using workspace: to implement nohoist in a package.json while using pnpm throws an error
1 participant