Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: removes 3rd party dependency 'indent-string' #940

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

sverweij
Copy link
Owner

@sverweij sverweij commented Jun 29, 2024

Description

  • removes 3rd party dependency 'indent-string'
  • replaces it with the simple string replace it ultimately comes down to (regex shamelessly copied from the indent-string package).

Motivation and Context

Less dependencies => less maintenance overhead. Moreover, the part of indent-string we actually use is so trivial it's simpler to pull it in.

How Has This Been Tested?

  • green ci

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/indent-string@5.0.0

View full report↗︎

Copy link

codeclimate bot commented Jun 29, 2024

Code Climate has analyzed commit 19d8538 and detected 0 issues on this pull request.

View more on Code Climate.

@sverweij sverweij merged commit c8f7fa1 into main Jun 29, 2024
11 checks passed
@sverweij sverweij deleted the refactor/removes-indent-string-dependency branch June 29, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant