Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support svelte 4 #948

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Conversation

kubotak-is
Copy link
Contributor

@kubotak-is kubotak-is commented Jul 16, 2024

Description

This pull request adds support for Svelte version 4. While Svelte's next version will be 5, this pull request provides support up to version 4.

Motivation and Context

Dependency Cruiser does not currently support the latest version of Svelte, which is version 4. This update aims to address that. The syntax between Svelte 3 and 4 has not fundamentally changed, so only minimal modifications were needed to support version 4.

https://svelte.dev/docs/v4-migration-guide

How Has This Been Tested?

  • green ci

Screenshots

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

Copy link

socket-security bot commented Jul 16, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/svelte@4.2.18 Transitive: unsafe +19 5.9 MB svelte-admin

🚮 Removed packages: npm/svelte@3.59.1

View full report↗︎

@kubotak-is kubotak-is changed the title feature(svelte):support svelte 4 feature(svelte): support svelte 4 Jul 16, 2024
@kubotak-is kubotak-is changed the title feature(svelte): support svelte 4 feat: support svelte 4 Jul 16, 2024
Copy link

codeclimate bot commented Jul 17, 2024

Code Climate has analyzed commit 759577d and detected 0 issues on this pull request.

View more on Code Climate.

@sverweij
Copy link
Owner

sverweij commented Jul 17, 2024

Hi @kubotak-is thanks for taking the time to research this and turning it in to a pull request! I was surprised adding support for svelte 4 looks so relatively straightforward.

Apparently an update to eslint and some caching crossed each other, resulting in a linting error that got nothing to do with your PR, sorry about that! I've added a commit (759577d2) to fix that.

@sverweij sverweij merged commit 72373ea into sverweij:main Jul 17, 2024
9 checks passed
@kubotak-is
Copy link
Contributor Author

@sverweij Thank you for promptly merging the pull request.

@sverweij
Copy link
Owner

sverweij commented Jul 18, 2024

Hi @kubotak-is as we speak the code in this PR is being published to npm as version 16.3.8 16.3.9. Thanks again!

(+ I've added you to the list of contributors in the package manifest)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants