Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replaces lodash #950

Merged
merged 5 commits into from
Jul 20, 2024
Merged

refactor: replaces lodash #950

merged 5 commits into from
Jul 20, 2024

Conversation

sverweij
Copy link
Owner

@sverweij sverweij commented Jul 20, 2024

Description

  • centralizes remaining uses of lodash in central utilities
  • in the central utilities replace the lodash array functions with native alternatives that work in our context
  • in the central utilities replace the lodash object functions with native alternatives that work in our context
  • removes lodash from the package manifest

Motivation and Context

lodash is a great library, however

  • it's not really maintained anymore
  • it has fairly large download size (1.4Mb according to pkg-size) - while we only use a small subset of it

How Has This Been Tested?

  • green ci

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

Copy link

socket-security bot commented Jul 20, 2024

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@types/lodash@4.17.7, npm/lodash@4.17.21

View full report↗︎

src/report/dot/index.mjs Outdated Show resolved Hide resolved
src/report/dot/theming.mjs Outdated Show resolved Hide resolved
src/report/dot/theming.mjs Outdated Show resolved Hide resolved
test/cli/index.spec.mjs Outdated Show resolved Hide resolved
Copy link

codeclimate bot commented Jul 20, 2024

Code Climate has analyzed commit b4bf557 and detected 0 issues on this pull request.

View more on Code Climate.

@sverweij sverweij merged commit 24b40be into main Jul 20, 2024
9 checks passed
@sverweij sverweij deleted the refactor/replace-lodash branch July 20, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant