Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extract): ignore entries in 'workspaces' arrays that aren't strings (instead of throwing) #955

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

sverweij
Copy link
Owner

@sverweij sverweij commented Aug 31, 2024

Description

  • ignore entries in 'workspaces' arrays that aren't strings, instead of throwing an exception

Yarn workspaces is an array of strings according to its documentation. Apparently is possible (and accepted?) to have other types than strings as well. Not sure whether that is valid, but at least it's happening in the field, witnessing #947, so we deal with it.

Motivation and Context

Addresses the error mentioned in #947 (and likely fixes it)

How Has This Been Tested?

  • green ci
  • additional automated non-regression tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

Copy link

codeclimate bot commented Aug 31, 2024

Code Climate has analyzed commit 76955a6 and detected 0 issues on this pull request.

View more on Code Climate.

@sverweij sverweij changed the title fix(extract): ignores entries in 'workspaces' arrays that aren't strings instead of throwing fix(extract): ignore entries in 'workspaces' arrays that aren't strings (instead of throwing) Aug 31, 2024
@sverweij sverweij merged commit e414c0a into main Aug 31, 2024
9 checks passed
@sverweij sverweij deleted the fix/filter-workspaces-arrays branch August 31, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant