Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: uses explicit exports over default where possible #956

Merged

Conversation

sverweij
Copy link
Owner

Description

  • uses explicit exports over default exports where possible

Motivation and Context

These were leftovers from the cjs -> mjs conversion that added a level of indirection we don't need.

How Has This Been Tested?

  • green ci
  • updated unit tests where applicable

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

@sverweij sverweij force-pushed the refactor/use-explicit-exports-over-default-where-possible branch from 05f6ebf to d25d5fd Compare September 20, 2024 19:16
Copy link

codeclimate bot commented Sep 20, 2024

Code Climate has analyzed commit d25d5fd and detected 0 issues on this pull request.

View more on Code Climate.

@sverweij sverweij merged commit 4314428 into main Sep 20, 2024
7 checks passed
@sverweij sverweij deleted the refactor/use-explicit-exports-over-default-where-possible branch September 20, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant