fix: null number field #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -192,15 +194,17 @@ def get_internal_type(self): | |||
|
|
|||
| def to_python(self, value): | |||
| # value is either an int or a string of an integer | |||
| if isinstance(value, self.number_type): | |||
| if isinstance(value, self.number_type) or value is None: | |||
There was a problem hiding this comment.
It is better to add import types to the top, and use if isinstance(value, (self.number_type, types.NoneType)): instead of if isinstance(value, self.number_type) or value is None:.
|
Thank you for contribution, but I lack of time to maintain this project. If you wish, I'll grant you access to this repository, so you'll be able to merge you patch yourself. But please, squash commits into one, add a meaningful commit description and write a test for this improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if number field is None, an exception will be raised.
So there's no way to make the number field nullable.