Fixed Conflicts of Pull Request https://github.com/svg-net/SVG/pull/1094 #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
pushed a commit
that referenced
this pull request
Dec 16, 2023
…CSS (#1107) --------- Co-authored-by: Kalachik Roman <kalachik@eremex.ru>
|
@inforithmics @mrbean-bremen Why do you only provide this feature for some In addition, I have a negative opinion about the way this functionality is provided from maintainability standpoint. In my opinion, I think you should just add |
|
I'll make a follow up pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes the Conflicts of this pull request
#1094
What does this implement/fix? Explain your changes.
SvgDocument has CSS support which is cool. But sometimes you may want to specify an external CSS for an SVG document. This MR adds one more parameter to the SvgDocument.Open method for external CSS.
Any other comments?