-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove net462 TargetFramework as net462 is supported by netstandard2.0 #1118
Conversation
@charlesroddie Thanks for the contribution. Please tiny up but keep the support for .NET 4.6.2.
Libraries like |
This PR doesn't remove support for .NET 4.6.2 since it retains
Svg.Skia targets
I am not competent to understand how SkiaSharp uses the dotnet project system to deploy to all platforms. Presumably it has explicit framework support because of all the platform-specific native bindings it needs to support? |
Looks like the reason for the failing tests is missing support for private fonts. From the test code: #if NETSTANDARD
// Private font does not work if .NET Standard.
protected override int ExpectedSize { get { return 3000; } } // 3155
#else
protected override int ExpectedSize { get { return 3200; } } // 3512
#endif Not sure why |
It works but packaging
Easy way, compare the output directory ( |
In SVG, I do not think it is possible to avoid private fonts, since loading any font file not installed on the system is private. |
@charlesroddie Thanks for the contribution. For now, we will keep net462 TargetFramework target. |
The net462 TargetFramework in svg.csproj is unnecessary as net462 is supported by netstandard.
This allows cleaning up some code using
#if
annotations forNet462
andNETFULL
.Some code is removed which only works on
Net462
:RegisterEvents
involving mice, andWeb/SvgHandler.cs
. It is assumed that these are legacy methods which are no longer needed as they work only on Net462.Tests and samples involving net462 are unchanged