Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed CS8352 in net8 #1121

Closed
wants to merge 1 commit into from
Closed

fixed CS8352 in net8 #1121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Source/DataTypes/SvgPointCollection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public override object ConvertFrom(ITypeDescriptorContext context, CultureInfo c
if (value is string s)
{
var coords = s.AsSpan().Trim();
var state = new CoordinateParserState(ref coords);
var state = new CoordinateParserState(coords);
var result = new SvgPointCollection();
while (CoordinateParser.TryGetFloat(out var pointValue, ref coords, ref state))
{
Expand Down
2 changes: 1 addition & 1 deletion Source/Paths/CoordinateParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public ref struct CoordinateParserState
public int Position;
public bool HasMore;

public CoordinateParserState(ref ReadOnlySpan<char> chars)
public CoordinateParserState(ReadOnlySpan<char> chars)
{
CurrNumState = NumState.Separator;
NewNumState = NumState.Separator;
Expand Down
6 changes: 3 additions & 3 deletions Source/Paths/SvgPathBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,14 @@ public static SvgPathSegmentList Parse(ReadOnlySpan<char> path)
if (command.Length > 0)
{
var commandSetTrimmed = pathTrimmed.Slice(start, length).Trim();
var state = new CoordinateParserState(ref commandSetTrimmed);
var state = new CoordinateParserState(commandSetTrimmed);
CreatePathSegment(commandSetTrimmed[0], segments, ref state, ref commandSetTrimmed);
}

if (pathLength == i + 1)
{
var commandSetTrimmed = pathTrimmed.Slice(i, 1).Trim();
var state = new CoordinateParserState(ref commandSetTrimmed);
var state = new CoordinateParserState(commandSetTrimmed);
CreatePathSegment(commandSetTrimmed[0], segments, ref state, ref commandSetTrimmed);
}
}
Expand All @@ -70,7 +70,7 @@ public static SvgPathSegmentList Parse(ReadOnlySpan<char> path)
if (command.Length > 0)
{
var commandSetTrimmed = pathTrimmed.Slice(start, length).Trim();
var state = new CoordinateParserState(ref commandSetTrimmed);
var state = new CoordinateParserState(commandSetTrimmed);
CreatePathSegment(commandSetTrimmed[0], segments, ref state, ref commandSetTrimmed);
}
}
Expand Down
4 changes: 2 additions & 2 deletions Tests/Svg.Benchmark/CoordinateParserBenchmarks.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,15 @@ public class CoordinateParserBenchmarks
public void CoordinateParser_TryGetBool()
{
var chars = "false".AsSpan().Trim();
var state = new CoordinateParserState(ref chars);
var state = new CoordinateParserState(chars);
CoordinateParser.TryGetBool(out var result, ref chars, ref state);
}

[Benchmark]
public void CoordinateParser_TryGetFloat_Points()
{
var chars = "1.6,3.2 1.2,5".AsSpan().Trim();
var state = new CoordinateParserState(ref chars);
var state = new CoordinateParserState(chars);
while (CoordinateParser.TryGetFloat(out var result, ref chars, ref state))
{
}
Expand Down
Loading