-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BoundsRelativeToTop #945
base: master
Are you sure you want to change the base?
Conversation
What benefits does this PR have for users ? |
It can determine where to overlay HTML elements over SVG (input boxes), or determine collisions between elements given changing transforms and coordinates. |
This is a behavior I have to emulate myself by applying parent transforms to the bounds myself, by the way. |
Can you give us concrete examples ? |
@Happypig375 Please explain the need for this feature. |
@paulushub - I would rely on @H1Gdev to review this - I don't really have the inside to say if this is helpful. |
Testing it now, having merged it into In fact, I am currently improving the quick test-run dialog to better compare before and after PR changes in the tests. |
Well, that looks like you have sufficiently reviewed it yourself! Just go ahead in this case... |
I originally wanted to implement clickable buttons given an area inside the SVG. I later wrote this as an extension method in my code. |
Thanks so much for the updates. The PR will still be around as we learn what to include. |
What does this implement/fix? Explain your changes.
There is currently no way to obtain the bounds of an element relative to the whole document instead of relative to the parent. This PR adds that.