-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimized out fill="#000" despite <g> shadowing #168
Comments
espadrine
added a commit
to badges/gh-badges
that referenced
this issue
Jan 8, 2014
This change was considered more legible by at least two folks. <badges/shields#95 (comment)> Also, the shadow isn't black in order to circumvent a bug in SVGO. <svg/svgo#168>
@silentroach, is this was fixed in #165/#166 as well? if so, it will be available in the next patch version. |
@deepsweet That's great news! (The above test case is on the latest v0.4.3.) |
Maybe it would nevertheless make sense to add a unit test for the above request |
@deepsweet yep, didn't see this issue |
ok :) v0.4.4 is coming soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reproducible with the following code.
Output:
Desired output:
In that case, the fill shadows the fill performed by the
<g>
, which has the effect of making the text invisible, when it should be black.(Obviously, this is a contrived example given as the reduced test-case of a larger image.)
The text was updated successfully, but these errors were encountered: