ci: run tests on windows #1853
Merged
ci: run tests on windows #1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SethFalco
force-pushed
the
ci/windows
branch
from
9797853 to
1ddd2aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an issue where platform-specific tests weren't kept up-to-date since they don't all run in CI, and active maintainers only use Linux/macOS.
This adds windows-latest in the test runners.
Running tests 8 times seems a bit much (build minutes + carbon footprint) but I'm also reluctant to drop Node v14 support until SVGO v4 is released. I'm thinking for now we go with this, but if we run into any problems, I can drop Node v14 support in a minor update instead.
Both Node v14 and Node v16 are no longer supported, so I think it's sensible to drop them soon. I'd like to take this one at a time though, so starting with Node v14. Node v16 only came out of its support window recently anyway.
Related