Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: output to new directory if trailing slash #1954

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

SethFalco
Copy link
Member

Previously, SVGO would crash if the output location had a trailing slash and the location didn't exist.

This should be behaving the same as when the directory did exist, and putting the optimized file with the same name inside that directory.

This fixes that behavior, so we'll treat this as if the user wants to create that directory and output the optimized SVG to a file with the same name in that directory.

See my comment in #1675 for more context:

Related

@SethFalco SethFalco merged commit c787b9f into svg:main Feb 5, 2024
8 checks passed
@SethFalco SethFalco deleted the fix/1675 branch February 5, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant