Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test for addClassesToSVGElement (currently failing). #816

Closed
wants to merge 1 commit into from
Closed

Added test for addClassesToSVGElement (currently failing). #816

wants to merge 1 commit into from

Conversation

keeganstreet
Copy link

Added test for addClassesToSVGElement to demonstrate that this plugin is currently failing.

  1) plugins tests
       addClassesToSVGElement.01:

      AssertionError: expected '<svg xmlns="http://www.w3.org/2000/svg" class="">\n    test\n</svg>' to be '<svg xmlns="http://www.w3.org/2000/svg" class="mySvg size-big">\n    test\n</svg>'
      + expected - actual

      -<svg xmlns="http://www.w3.org/2000/svg" class="">
      +<svg xmlns="http://www.w3.org/2000/svg" class="mySvg size-big">
           test
       </svg>

@strarsis
Copy link
Contributor

strarsis commented Oct 25, 2017

@keeganstreet: With #592 Element.classList property support has been added.
Using it in plugin should make the plugin much, much simpler and also fix this issue.

@GreLI
Copy link
Member

GreLI commented Oct 25, 2017

Thanks to both for your attention! Fixed in b51192c.

@GreLI GreLI closed this Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants