Tracing initialization improvements #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, it was possible that tests would overwrite each other's intended logging configuration.
… instead of through a prelude wildcard import.
svix-james
approved these changes
Mar 1, 2024
|
This is a great change. I don't know whether it will actually fix our problems related to testing, though. For example, when I've tried to instrument tests to reconfigure the tracer per test, I've had no luck. If I make a direct call to |
svix-jplatte
added a commit
that referenced
this pull request
Mar 14, 2024
Since #1244, we were no longer installing a global tracing subscriber that would print logs from (failing) tests. With this, we do again. First two commits are drive-by improvements in response to local warnings from my nightly toolchain about redundant imports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it was possible that tests would overwrite each other's intended logging configuration.