Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

soft-require typhoeus #1486

Merged
merged 1 commit into from
Oct 17, 2024
Merged

soft-require typhoeus #1486

merged 1 commit into from
Oct 17, 2024

Conversation

jjb
Copy link
Contributor

@jjb jjb commented Oct 16, 2024 •
edited
Loading

resolves #453

@jjb jjb requested a review from a team as a code owner October 16, 2024 23:11
@jjb jjb mentioned this pull request Oct 16, 2024
Closed
svix-gabriel
svix-gabriel approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@svix-gabriel svix-gabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for tackling this!

@svix-gabriel svix-gabriel merged commit 6c1525a into svix:main Oct 17, 2024
3 checks passed
@jjb jjb deleted the soft-require-typhoeus branch October 17, 2024 20:58
@jjb
Copy link
Contributor Author

jjb commented Oct 17, 2024

@svix-gabriel thanks for merging! I wasn't expecting it to get merged without discussion 😅. I didn't test it!

  • someone should test it
  • maybe you want to adjust the copy
  • maybe you want to inform your support / customer success / customer solutions / etc. teams, there may be additional support load from this

@jjb
Copy link
Contributor Author

jjb commented Oct 23, 2024

@svix-gabriel when do you think the next ruby gem version can be published?

@svix-gabriel
Copy link
Contributor

@jjb I'm not certain, but it should be fairly soon. We have some other changes to the libs that we're actively making before we cut a new release, but they should be done within a week or two.

@adrian-gomez adrian-gomez mentioned this pull request Jan 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svix-gabriel svix-gabriel svix-gabriel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Ruby gem hard-dependency on typhoeus
2 participants
@jjb @svix-gabriel