Bridge: add check for missing dynamic libs #1517
Merged
+18
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The v1.39 tag on docker hub currently fails with:
```
docker run --rm -it -e SVIX_BRIDGE_CFG='{}' docker.io/svix/svix-bridge:v1.39.0
svix-bridge: error while loading shared libraries: libssl.so.3: cannot open shared object file: No such file or directory
```
This diff adds script to look at the output from `ldd` and see if there
are libs that aren't found.
The version of the Dockerfile in main currently seems to pass this
check. Removing the cacert install gets us back to a failing state, so
we can see the script working:
```
Step 17/22 : USER appuser
---> Using cache
---> 80f72cf25adf
Step 18/22 : COPY --from=build /app/target/release/svix-bridge /usr/local/bin/svix-bridge
---> Using cache
---> 1bcafc142c09
Step 19/22 : COPY scripts/check-deps.sh /usr/local/bin/check-deps.sh
---> bc8108762915
Step 20/22 : RUN /usr/local/bin/check-deps.sh /usr/local/bin/svix-bridge
---> Running in 31cae75a107d
Binary /usr/local/bin/svix-bridge missing dependencies:
libssl.so.3 => not found
libcrypto.so.3 => not found
The command '/bin/sh -c /usr/local/bin/check-deps.sh /usr/local/bin/svix-bridge' returned a non-zero code: 1
```
This should help to catch other dependency-related problems that will
show up at runtime.
svix-onelson
force-pushed
the
onelson/bridge-docker-build
branch
from
aeac850
to
b397ae9
Compare
|
😎 |
svix-james
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The v1.39 tag on docker hub currently fails with:
This diff adds script to look at the output from
lddand see if there are libs that aren't found.The version of the Dockerfile in main currently seems to pass this check. Removing the cacert install gets us back to a failing state, so we can see the script working:
This should help to catch other dependency-related problems that will show up at runtime.