Updated Middleware discussion to include middleware returns so that p… #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rocessing continues. Also included example of where to put the middleware config object when adding the middleware to redux
compwright
suggested changes
Apr 2, 2018
| }, | ||
| error: function ({getState, dispatch, getSourceAction}, error) { | ||
| //... | ||
| return response |
There was a problem hiding this comment.
Typo - should this be return Promise.reject(error); ?
There was a problem hiding this comment.
I think so but let me test to make sure.
|
thank you for your support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rocessing continues. Also included example of where to put the middleware config object when adding the middleware to redux
I'm not 100% sure I did the returns properly and that my renaming req to res was the right thing to do.