Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): add --plugin to define plugin and options #11

Merged
merged 5 commits into from
Jul 12, 2019
Merged

feat(cli): add --plugin to define plugin and options #11

merged 5 commits into from
Jul 12, 2019

Conversation

xuchaoying
Copy link
Member

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

feature

  • What is the related issue? (Use #issue_id to relate an open issue)

  • Does this PR introduce a breaking change?

Yes, it changed the way to define plugin options, and removed the old way --markdown.foo bar.

  • Other information:

@xuchaoying xuchaoying added the PR: enhancement :nail_care: Enhancement label Jul 12, 2019
@xuchaoying xuchaoying requested a review from leeluolee July 12, 2019 08:55
@xuchaoying xuchaoying added PR: new feature :rocket: New Feature and removed PR: enhancement :nail_care: Enhancement labels Jul 12, 2019
@xuchaoying xuchaoying requested a review from teshoudong July 12, 2019 09:10
@xuchaoying xuchaoying merged commit 777a09c into master Jul 12, 2019
@xuchaoying xuchaoying deleted the cli-plugin branch July 12, 2019 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teshoudong teshoudong teshoudong approved these changes

@leeluolee leeluolee Awaiting requested review from leeluolee

Assignees
No one assigned
Labels
PR: new feature :rocket: New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xuchaoying @teshoudong