Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: routing update not working #119

Merged
merged 2 commits into from
Oct 12, 2019
Merged

fix: routing update not working #119

merged 2 commits into from
Oct 12, 2019

Conversation

leeluolee
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the related issue? (Use #issue_id to relate an open issue)

  • Does this PR introduce a breaking change?

  • Other information:

@leeluolee leeluolee requested a review from xuchaoying October 11, 2019 12:21
@codecov
Copy link

codecov bot commented Oct 12, 2019

Codecov Report

Merging #119 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #119   +/-   ##
=======================================
  Coverage   92.16%   92.16%           
=======================================
  Files          44       44           
  Lines        1596     1596           
=======================================
  Hits         1471     1471           
  Misses        125      125
Impacted Files Coverage Δ
packages/svrx/lib/router/loader.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34dbbb8...a41d77e. Read the comment docs.

@xuchaoying xuchaoying added the PR: bug fix :bug: Bug Fix label Oct 12, 2019
@xuchaoying xuchaoying merged commit 91298f6 into master Oct 12, 2019
@xuchaoying xuchaoying deleted the fix-route-update branch October 12, 2019 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: bug fix :bug: Bug Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants