Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix number check for option value #77

Merged
merged 3 commits into from
Sep 2, 2019
Merged

Conversation

xuchaoying
Copy link
Member

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

bug fix

  • What is the related issue? (Use #issue_id to relate an open issue)

  • Does this PR introduce a breaking change?

no

  • Other information:

@xuchaoying xuchaoying self-assigned this Sep 2, 2019
@xuchaoying xuchaoying added the PR: bug fix :bug: Bug Fix label Sep 2, 2019
@xuchaoying xuchaoying requested a review from leeluolee September 2, 2019 04:00
@codecov
Copy link

codecov bot commented Sep 2, 2019

Codecov Report

Merging #77 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #77   +/-   ##
======================================
  Coverage    91.8%   91.8%           
======================================
  Files          44      44           
  Lines        1561    1561           
======================================
  Hits         1433    1433           
  Misses        128     128
Impacted Files Coverage Δ
packages/svrx/lib/configure/index.js 98.69% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c012bbd...26a0438. Read the comment docs.

@xuchaoying xuchaoying merged commit d82a13c into master Sep 2, 2019
@xuchaoying xuchaoying deleted the cy-fix-config-number branch September 2, 2019 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: bug fix :bug: Bug Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants