Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encore fails to start if redis server is not configured to allow CONFIG command #25

Closed
grusell opened this issue Mar 27, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@grusell
Copy link
Contributor

grusell commented Mar 27, 2024

Describe the bug
If using a redis server that does not allow the CONFIG command, encore fails to start. Many/some commercial managed redis service (azure redis cache, aws redis cache) does not allow the CONFIG command and therefore can not be used together with encore.

It seems pring data redis uses the CONFIG command to set the 'notify-keyspace-events' property. In managed redis services, this can usually be configured in some other way, so it would make sense if this behaviour of spring data redis could be disabled.

I will provide a PR to fix this.

To Reproduce
Steps to reproduce the behavior:

  1. Add rename-command CONFIG "" to the config of your redis server
  2. Run encore
  3. Encore will fail to start

Expected behavior
It should be possible to configure encore to run even if the CONFIG command is disabled. For correct funcionality this will probably requiring configuring notify-keyspace-events on the server through some other means.

@fhermansson
Copy link
Collaborator

Fixed in v0.2.6. Thank you Gustav.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants