Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mark present url api #2520

Closed
DeD1rk opened this issue Sep 28, 2022 · 0 comments · Fixed by #2610
Closed

Add mark present url api #2520

DeD1rk opened this issue Sep 28, 2022 · 0 comments · Fixed by #2610
Labels
api Issues related to the API app:events Issues regarding the events-app easy and fun Easy to solve feature Issues regarding a complete new feature priority: low Should be dealt with when nothing else remains.

Comments

@DeD1rk
Copy link
Member

DeD1rk commented Sep 28, 2022 •
edited
Loading

See #2465. To render that QR code on the app, we need to either add the url in the qr to the api, or decide that the app should load an image from the same view that's used in the admin (this would be more complicated for authentication).

Furthermore, there should be an endpoint the app can use after accepting the mark present url as a deeplink.
@DeD1rk DeD1rk added priority: low Should be dealt with when nothing else remains. easy and fun Easy to solve app:events Issues regarding the events-app feature Issues regarding a complete new feature api Issues related to the API labels Sep 28, 2022
@DeD1rk DeD1rk changed the title Add Event.mark_present_url to the event admin API Add mark present url api Sep 28, 2022
@DeD1rk DeD1rk mentioned this issue Sep 28, 2022
Closed
@DeD1rk DeD1rk mentioned this issue Oct 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api Issues related to the API app:events Issues regarding the events-app easy and fun Easy to solve feature Issues regarding a complete new feature priority: low Should be dealt with when nothing else remains.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add mark-present api svthalia/concrexit
1 participant
@DeD1rk