Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mark-present api #2610

Merged
merged 2 commits into from
Oct 26, 2022
Merged

Add mark-present api #2610

merged 2 commits into from
Oct 26, 2022

Conversation

DeD1rk
Copy link
Member

@DeD1rk DeD1rk commented Oct 21, 2022

Closes #2520.

Summary

Adds an api view basically identical to that at the mark-present-url, but using PATCH. And adds the mark_present_url to the event admin serializer.

How to test

Steps to test the changes you made:

  1. Try to mark yourself as present with the api.

Adds an api view basically identical to that at the mark-present-url,
but using PATCH. And adds the mark_present_url to the event admin serializer.
@DeD1rk DeD1rk requested a review from JobDoesburg October 21, 2022 12:56
@github-actions github-actions bot added app:events Issues regarding the events-app app:sales Issues regarding the sales-app labels Oct 21, 2022
@DeD1rk DeD1rk force-pushed the add-mark-present-api branch from 1943412 to 3ac4681 Compare October 21, 2022 14:15
@codeclimate
Copy link

codeclimate bot commented Oct 21, 2022

Code Climate has analyzed commit 3ac4681 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

@DeD1rk DeD1rk marked this pull request as draft October 26, 2022 11:01
@DeD1rk DeD1rk marked this pull request as ready for review October 26, 2022 17:29
@DeD1rk DeD1rk merged commit 92a31b7 into master Oct 26, 2022
@DeD1rk DeD1rk deleted the add-mark-present-api branch October 26, 2022 18:06
JobDoesburg pushed a commit that referenced this pull request Nov 16, 2022
* Add mark-present api

Adds an api view basically identical to that at the mark-present-url,
but using PATCH. And adds the mark_present_url to the event admin serializer.

* Fix linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:events Issues regarding the events-app app:sales Issues regarding the sales-app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add mark present url api
2 participants