Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data retention period to event information fields #2296

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

JobDoesburg
Copy link
Contributor

Closes #1949

Summary

Adds a data retention period to event info fields

How to test

@github-actions github-actions bot added the app:events Issues regarding the events-app label Apr 15, 2022
@codeclimate
Copy link

codeclimate bot commented Apr 15, 2022

Code Climate has analyzed commit 63bfb05 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

@se-bastiaan se-bastiaan changed the title Delete event information fields Add data retention period to event information fields Apr 20, 2022
@@ -40,6 +40,15 @@ class RegistrationInformationField(models.Model):
_("required"),
)

delete_after = models.DateField(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we delete this after a predetermined time? This way it could technically be saved forever if people enter a value that is years in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also possible. The reason I opened the issue myself is because we don't have an exact policy on this, and regarding data minimization I figure that some kinds of data might have different retention times than others and this forces organizers to think about it. We could add a validator of max 3 years or something. But I'm open for discussion on this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would personally say that 1/2-ish months after the activity ended would also be fine. So many options. As long as it is not 'unlimited'.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a constant? Or as max value?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Constant

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, as you can see (we do anonymize it, we don't delete it)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I think 2 months after the event is over we can delete the registration info

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep it this way. Force people to think about what to do with this data.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it a bit our job to have thought about this for them?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, because we don't know what kind of data this is, so we are not able to make a judgement on what the retention period should be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:events Issues regarding the events-app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically remove registration information fields
3 participants