-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add data retention period to event information fields #2296
base: master
Are you sure you want to change the base?
Conversation
Code Climate has analyzed commit 63bfb05 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
@@ -40,6 +40,15 @@ class RegistrationInformationField(models.Model): | |||
_("required"), | |||
) | |||
|
|||
delete_after = models.DateField( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't we delete this after a predetermined time? This way it could technically be saved forever if people enter a value that is years in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also possible. The reason I opened the issue myself is because we don't have an exact policy on this, and regarding data minimization I figure that some kinds of data might have different retention times than others and this forces organizers to think about it. We could add a validator of max 3 years
or something. But I'm open for discussion on this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would personally say that 1/2-ish months after the activity ended would also be fine. So many options. As long as it is not 'unlimited'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a constant? Or as max value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Constant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, as you can see (we do anonymize it, we don't delete it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then I think 2 months after the event is over we can delete the registration info
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should keep it this way. Force people to think about what to do with this data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it a bit our job to have thought about this for them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, because we don't know what kind of data this is, so we are not able to make a judgement on what the retention period should be.
41d42a7
to
18edd09
Compare
Closes #1949
Summary
Adds a data retention period to event info fields
How to test