Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement JSON Schema 2019-09 namespace #4662

Merged
merged 3 commits into from
Jan 21, 2025
Merged

feat: implement JSON Schema 2019-09 namespace #4662

merged 3 commits into from
Jan 21, 2025

Conversation

glowcloud
Copy link
Contributor

Refs #1819

@glowcloud glowcloud added enhancement New feature or request JSON Schema JSON Schema related work labels Jan 20, 2025
@glowcloud glowcloud requested a review from char0n January 20, 2025 09:03
@glowcloud glowcloud self-assigned this Jan 20, 2025
char0n
char0n requested changes Jan 20, 2025
View reviewed changes
Copy link
Member

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First batch review complete

packages/apidom-ns-json-schema-2019-09/README.md Outdated Show resolved Hide resolved
packages/apidom-ns-json-schema-2019-09/README.md Outdated Show resolved Hide resolved
packages/apidom-ns-json-schema-2019-09/src/index.ts Outdated Show resolved Hide resolved
packages/apidom-ns-json-schema-2019-09/src/index.ts Outdated Show resolved Hide resolved
packages/apidom-ns-json-schema-2019-09/src/index.ts Outdated Show resolved Hide resolved
char0n
char0n approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Haven't find anything. Nice work!

@glowcloud glowcloud merged commit 6b208ed into main Jan 21, 2025
8 checks passed
@glowcloud glowcloud deleted the 1819-ns-json-schema-2019-09 branch January 21, 2025 09:54
@glowcloud glowcloud mentioned this pull request Jan 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@char0n char0n char0n approved these changes

Assignees

@glowcloud glowcloud

Labels
enhancement New feature or request JSON Schema JSON Schema related work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glowcloud @char0n