Fix recursion failure when generating examples #431
Conversation
| return schema.getExample(); | ||
| } | ||
| processedModels.add(name); | ||
| processedModels.add(schema.get$ref()); |
There was a problem hiding this comment.
These processedModels are passed to resolveSchemaToExample() at line 290.
I changed this from using the name because names are not guaranteed to be unique within an object tree. For example, an id property on the top-level schema could be redundant with an id in a nested object. In the case of a self-referencing or circular structure, names are certain not to be unique.
|
hello @scottydawg, thanks a lot for PR, i reviewed and it does fix the stackoverflow issue, but add another one, usually for petstore sample in aspnet generated code we use to get an example json of the schemas, however with your changes we're getting this output: i'll try to work with your chages and improve the class in order to merge the PR, thanks! |
This fixes an issue documented in Issue 9546 in the swagger-codegen repo. The ExampleGenerator recurses infinitely when a schema object is self-referencing.
This fixes the issue by indexing the processed models by their schema reference, and returning existing examples when they already exist.