[typescript-fetch] use isomorphic-fetch #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
typescript-fetch, the generated client uses theportable-fetchpackage. It's a fork of the very popularisomorphic-fetchpackage. The fork has been unmaintained for 4 years and provides no documentation on its motives.This PR replaces the fork with the original (more up to date) package. I think it's not good for codegen to rely on random forks for such simple tasks (a polyfill for
fetch()). If users have specific needs regarding thefetch()implementation, the generated code allows them to pass it on the constructor.