TypeScript Fetch client doesn't support multipart/form-data body #3921
Description
Description
If a POST operation accepts multipart/form-data, the typescript-fetch client posts an application/x-www-form-urlencoded body instead of form data.
Swagger-codegen version
Version currently deployed on [editor.swagger.io]
Swagger declaration file content or url
swagger: '2.0'
info: { version: 0.1.0, title: Multipart Upload }
paths:
/:
post:
operationId: upload
consumes:
- multipart/form-data
parameters:
- name: file
in: formData
required: true
type: file
responses: { '200': { description: Successful upload } }Command line used for generation
"Generate Client" -> "TypeScript Fetch" on [editor.swagger.io]
Steps to reproduce
- Generate and compile the sample config
- Call it with a file
- Log the request, it has a
Content-Typeofapplication/x-www-form-urlencodedinstead ofmultipart/form-data.
Suggest a Fix
Instead of setting the Content-Type and using querystring to serialize the contents (for multipart/form-data requests), it should just set the body to an instance of FormData instead of
e.g., in DefaultApiFetchParamCreactor#upload, instead of :
let contentTypeHeader: Dictionary<string>;
contentTypeHeader = { "Content-Type": "application/x-www-form-urlencoded" };
fetchOptions.body = querystring.stringify({
"file": params.file,
});
if (contentTypeHeader) {
fetchOptions.headers = contentTypeHeader;
}it should generate (as Content-Type is set to multipart/form-data automatically if using FormData):
const formData = new FormData();
formData.append("file", params.file);
fetchOptions.body = formData;