[PHP][Silex] Generated parameters don't use same naming conventions as path variables

[PisaJan]

Description

PHP SILEX server generator doesn't use same naming conventions for path variables and function parameters.

Eg. like this:

$app->GET('/pet/{petId}', function(Application $app, Request $request, $pet_id)

When trying to GET that URI, you get:

RuntimeException in ControllerResolver.php line 126:
Controller "Closure" requires that you provide a value for the "$pet_id" argument (because there is no default value or because there is a non optional argument after this one).

Swagger-codegen version

swagger: '2.0'
info:
version: 1.0.0
title: PetStore on Heroku

Swagger declaration file content or url

I am using defalt Pet store example.

[wing328]

@PisaJan thanks for reporting the issue. Are you saying that the variable $per_id should have named as $petId instead?

[PisaJan]

@wing328 Happy to help. Yes, exactly. Otherwise Silex is not able to pair path variables to parameters.

[arnested]

I can confirm that as well (although I never got around to debugging it or reporting it).

[wing328]

@PisaJan @arnested so a workaround is not to rename variable to snake case and just keep the original naming?

We can introduce the following options (currently used by Typescript):

    modelPropertyNaming
        Naming convention for the property: 'camelCase', 'PascalCase', 'snake_case' and 'original', which keeps the original name (Default: camelCase)
```

[PisaJan]

@wing328 I guess so, it's working fine for:
$app->GET('/pets/{petId}', function(Application $app, Request $request, $petId)
So you just need to use same naming convention for path and for function.

[wing328]

@PisaJan may I know if you've time to add modelPropertyNaming to PHP Slim generator?

For reference, here is the PR to add modelPropertyNaming for Scala:#3685

[PisaJan]

@wing328 I am sorry, but I am currently working for the company and my personal time schedule is also a little busy.

[paulmasri]

If you've been foolish/naive enough to have used PascalCase, you get the same issue.
e.g. $app->GET('/pet/{PetId}', function(Application $app, Request $request, $pet_id)

[wing328]

@PisaJan @paulmasri I should be able to fix it (with a workaround using the original name of the parameter). Would you have time to help test the fix?