maximum, minimum are now stored as BigDecimal

[wing328]

Description

maximum, minimum are now stored as BigDecimal

Ref: https://github.com/swagger-api/swagger-core/blob/72495dc1e7a458fd34b20c271b08a56f44d37849/modules/swagger-models/src/main/java/io/swagger/models/properties/AbstractNumericProperty.java

and the value in the mustuche template has changed accordingly. Here is an example showing the differences:

diff --git a/samples/client/petstore/php/SwaggerClient-php/lib/Api/FakeApi.php b/samples/client/petstore/php/SwaggerC
lient-php/lib/Api/FakeApi.php
index 9d13660..465c520 100644
--- a/samples/client/petstore/php/SwaggerClient-php/lib/Api/FakeApi.php
+++ b/samples/client/petstore/php/SwaggerClient-php/lib/Api/FakeApi.php
@@ -226,22 +226,22 @@ class FakeApi
         if ($number === null) {
             throw new \InvalidArgumentException('Missing the required parameter $number when calling testEndpointPar
ameters');
         }
-        if (($number > 543.2)) {
-            throw new \InvalidArgumentException('invalid value for "$number" when calling FakeApi.testEndpointParameters, must be smaller than or equal to 543.2.');
+        if (($number > 543.200000000000045474735088646411895751953125)) {
+            throw new \InvalidArgumentException('invalid value for "$number" when calling FakeApi.testEndpointParameters, must be smaller than or equal to 543.200000000000045474735088646411895751953125.');
         }
-        if (($number < 32.1)) {
-            throw new \InvalidArgumentException('invalid value for "$number" when calling FakeApi.testEndpointParameters, must be bigger than or equal to 32.1.');
+        if (($number < 32.10000000000000142108547152020037174224853515625)) {
+            throw new \InvalidArgumentException('invalid value for "$number" when calling FakeApi.testEndpointParameters, must be bigger than or equal to 32.10000000000000142108547152020037174224853515625.');
         }
 
         // verify the required parameter 'double' is set
         if ($double === null) {
             throw new \InvalidArgumentException('Missing the required parameter $double when calling testEndpointParameters');
         }
-        if (($double > 123.4)) {
-            throw new \InvalidArgumentException('invalid value for "$double" when calling FakeApi.testEndpointParameters, must be smaller than or equal to 123.4.');
+        if (($double > 123.400000000000005684341886080801486968994140625)) {
+            throw new \InvalidArgumentException('invalid value for "$double" when calling FakeApi.testEndpointParameters, must be smaller than or equal to 123.400000000000005684341886080801486968994140625.');
         }
-        if (($double < 67.8)) {
-            throw new \InvalidArgumentException('invalid value for "$double" when calling FakeApi.testEndpointParameters, must be bigger than or equal to 67.8.');
+        if (($double < 67.7999999999999971578290569595992565155029296875)) {
+            throw new \InvalidArgumentException('invalid value for "$double" when calling FakeApi.testEndpointParameters, must be bigger than or equal to 67.7999999999999971578290569595992565155029296875.');
         }

We need a proper value of converting the BigDecimal to string

Swagger-codegen version

Latest master

Swagger declaration file content or url

Swagger Petstore

Command line used for generation

./bin/php-petstore.sh

Steps to reproduce

./bin/php-petstore.sh
git diff

[wing328]

@fehguy seems like Swagger Parser is not obtaining the maximum/minimum via the string constructor of BigDecimal and as a result the original value cannot be obtained. Here is the log showing getMaximum, getMinimum:

[main] INFO io.swagger.codegen.AbstractGenerator - writing file /var/apps/wing328/swagger-codegen/samples/client/petstore/php/SwaggerClient-php/lib/Model/User.php
[main] INFO io.swagger.codegen.DefaultGenerator - File exists. Skipped overwriting /var/apps/wing328/swagger-codegen/samples/client/petstore/php/SwaggerClient-php/test/Model/UserTest.php
[main] INFO io.swagger.codegen.AbstractGenerator - writing file /var/apps/wing328/swagger-codegen/samples/client/petstore/php/SwaggerClient-php/docs/Model/User.md
[main] INFO io.swagger.codegen.DefaultCodegen - min = 1
[main] INFO io.swagger.codegen.DefaultCodegen - max = 543.200000000000045474735088646411895751953125
[main] INFO io.swagger.codegen.DefaultCodegen - min = 32.10000000000000142108547152020037174224853515625
[main] INFO io.swagger.codegen.DefaultCodegen - max = 987.6000000000000227373675443232059478759765625
[main] INFO io.swagger.codegen.DefaultCodegen - max = 123.400000000000005684341886080801486968994140625
[main] INFO io.swagger.codegen.DefaultCodegen - min = 67.7999999999999971578290569595992565155029296875
[main] INFO io.swagger.codegen.AbstractGenerator - writing file /var/apps/wing328/swagger-codegen/samples/client/petstore/php/SwaggerClient-php/lib/Api/FakeApi.php
[main] INFO io.swagger.codegen.DefaultGenerator - File exists. Skipped overwriting /var/apps/wing328/swagger-codegen/samples/client/petstore/php/SwaggerClient-php/test/Api/FakeApiTest.php

Ref: http://stackoverflow.com/a/13900212/677735

It was working fine before the parser upgrade (which stores the values as double instead of BigDecimal)

[fehguy]

Oddly I believe the parser is using the string values for constructing the BigDecimal values, which allows the BigDecimal string cache to work. I'll dig into this more.

@wing328 can you please share a spec that exhibits this?

[wing328]

@fehguy I use the following to repeat the issue:

https://github.com/swagger-api/swagger-codegen/blob/master/modules/swagger-codegen/src/test/resources/2_0/petstore-with-fake-endpoints-models-for-testing.yaml

You can also run ./bin/php-pestore.sh and then git diff on the latest master to look at the differences in the auto-generated PHP API client.

[fehguy]

Thanks. I've added parser tests to verify it's doing the right thing, and I can reproduce what you're seeing. I'll report back.

[fehguy]

OK found the issue, fixed in 1.0.26-SNAPSHOT. Tests are here:

swagger-api/swagger-parser@f833882

[wing328]

@fehguy thanks. I could no longer repeat the issue with the latest master.

[fehguy]

I will get a parser release out and update master accordingly