[JAVA] VM arguments -DapiPackage, -DmodelPackage, -DinvokerPackage not working

[glpayson]

Description

When generating Java client VM arguments -DapiPackage, -DmodelPackage, -DinvokerPackage are not working (or I'm not doing it right).

Swagger-codegen version

jar built from master

Swagger declaration file content or url

http://petstore.swagger.io/v2/swagger.json

Command line used for generation / Steps to reproduce

git clone https://github.com/swagger-api/swagger-codegen
cd swagger-codegen
mvn clean package
cd ..

java -DinvokerPackage="com.mycompany.foo" \
    -DmodelPackage="com.mycompany.foo.model" \
    -DapiPackage="com.mycompany.foo.api" \
    -jar swagger-codegen/modules/swagger-codegen-cli/target/swagger-codegen-cli.jar generate \
    -i http://petstore.swagger.io/v2/swagger.json \
    -l java \
    -o testing_vm_args \
    >codegen_out 2>&1

Output

gist. Note that all packages are the default /io/swagger/

[ePaul]

Hmm, interresting.
If you put those arguments after the generate command, it works:

java -jar swagger-codegen/modules/swagger-codegen-cli/target/swagger-codegen-cli.jar generate \
    -DinvokerPackage="com.mycompany.foo" \
    -DmodelPackage="com.mycompany.foo.model" \
    -DapiPackage="com.mycompany.foo.api" \
    -i http://petstore.swagger.io/v2/swagger.json \
    -l java \
    -o testing_vm_args \
    >codegen_out 2>&1

I'm not really sure why the first way doesn't work.

(I added this syntax recently in #5191, previously you would have to use -DinvokerPackage=com.mycompany.foo,modelPackage=com.mycompany.foo.model,apiPackage=com.mycompany.foo.api, but that should not have changed anything about using the real system properties.)

But I guess the preferred way would be this one:

java -jar swagger-codegen/modules/swagger-codegen-cli/target/swagger-codegen-cli.jar generate \
    --invoker-package "com.mycompany.foo" \
    --model-package "com.mycompany.foo.model" \
    --api-package "com.mycompany.foo.api" \
    -i http://petstore.swagger.io/v2/swagger.json \
    -l java \
    -o testing_vm_args \
    >codegen_out 2>&1

A first guess, without digging into the code yet: Maybe the evaluation order of the different options and their defaults is such that the system properties get overridden by the defaults.