Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request: Liberate DefaultGenerator! #7722

Closed
DarkWingDuckWing opened this issue Feb 25, 2018 · 3 comments
Closed

Request: Liberate DefaultGenerator! #7722

DarkWingDuckWing opened this issue Feb 25, 2018 · 3 comments

Comments

@DarkWingDuckWing
Copy link
Contributor

Description

Hey all,

I'm looking to get creative with my generated APIs/Controllers and it looks like there's a few private methods in DefaultGenerator that would really benefit me if they were to be made protected. For instance, the private void generateApis(List<File> files, List<Object> allOperations, List<Object> allModels) is a great target to be able to override in order to customize logic around the operations on a path/endpoint.

Let me know what you think and I can open up a PR.
@macjohnny
Copy link
Contributor

@dankling I think this sounds reasonable

@DarkWingDuckWing DarkWingDuckWing mentioned this issue May 30, 2018
Closed
3 tasks
@frantuma frantuma mentioned this issue Jan 30, 2019
Merged
frantuma added a commit that referenced this issue Jan 30, 2019
@frantuma
Merge pull request #9136 from swagger-api/feature/7722-liberate-defau…
377174f 
…ltgenerator

change DefaultGenerator members visibility - ref #7722
@frantuma
Copy link
Member

Thanks! implemented in #9136 (includes #8097)

@DarkWingDuckWing
Copy link
Contributor Author

Could we get these changes on the 3 release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@macjohnny @DarkWingDuckWing @frantuma