isEnum returns false when enum is referenced

[kolisko]

Description

When is defined enum as standalone type and is referenced from elsewhere, template var isEnum is set to false.

Swagger-codegen version

<dependency>
            <groupId>io.swagger</groupId>
            <artifactId>swagger-codegen-cli</artifactId>
            <version>2.3.1</version>
        </dependency>

Swagger declaration file content or url

definitions:
 UIDocumentsOverviewLock:
    type: object
    properties:
      action:
        $ref: '#/definitions/InvalidateDocsAction'
 InvalidateDocsAction:
    type: string
    enum:
      - FINAL
      - INDIVIDUALIZED
      - FC_NOT_INDIVIDUALIZED
      - FC_AND_INDIVIDUALIZED

Command line used for generation

Steps to reproduce

in mustasche template is isEnum false on property 'action' and should be true because InvalidateDocsAction is defined as enum.

Related issues/PRs

Suggest a fix/enhancement

Checking the referenced class type

[jmini]

Can you elaborate on this?
I am not not sure that what you are describing is correct.

When the action property is generated, it represents a binding to an existing Object: io.swagger.model.InvalidateDocsAction. The InvalidateDocsAction class is an enum, the binding is not.

This is different than when the enums values are defined directly in the property:

definitions:
  UIDocumentsOverviewLock:
    type: object
    properties:
      action:
        type: string
        enum:
          - FINAL
          - INDIVIDUALIZED
          - FC_NOT_INDIVIDUALIZED
          - FC_AND_INDIVIDUALIZED

In this second case, an inner-enum is generated.

[Kdan]

Having the same issue.

[marcelion]

Same issue here.

[jmini]

Well... You are right, there should be no differences between having an inline definition or having a ref.

I do not agree on the way $ref is working now (you can not define type bindings), but this is an other story => OAI/OpenAPI-Specification#556

[williamd67]

I have the same issue and also when a reference is marked as an XML-attribute by adding

"xml": {
   "attribute": true
}

I also found a possible place this could be fixed:

• package io.swagger.codegen;
• class DefaultCodegen
• method addVars
• line 3149 (2.4.0 - commit 4607a90) where properties of RefProperty are copied. Currently isEnum and isXmlAttribute are not set.
  When the following lines are injected after line 3156 both isEnum and isXmlAttribute have the correct values. I do not know if this is the correct place or that more properties should be copied there.

if (modelImpl.getXml() != null && modelImpl.getXml().getAttribute() != null) {
    cp.isXmlAttribute = modelImpl.getXml().getAttribute();
}
cp.isEnum = (modelImpl.getEnum() != null);

[Oduig]

This issue causes a bug where client and server code in C# are slightly misaligned. Can anyone comment if the above fix works, and how this relates to pull request #6851?

[Oduig]

Created a pull request to fix this issue. Can someone take a look at it?