-
Notifications
You must be signed in to change notification settings - Fork 6k
Description
Description
Controller does not have container property which is being accessed in the code.
#6842 introduced access to container property of the BaseController. At this point Controller did not have container property anymore since the inheritance from the Base Symfony Controller was removed in #6615. These changes were incompatible and now any generated php-symfony code will fail should any exception be thrown down the stack and caught by the Controller.
Example of an invalid Controller: https://github.com/swagger-api/swagger-codegen/blob/master/samples/server/petstore/php-symfony/SymfonyBundle-php/Controller/Controller.php#L149
Swagger-codegen version
2.3.0, 2.3.1, master
Swagger declaration file content or url
Any swagger file, example: https://github.com/swagger-api/swagger-codegen/blob/master/modules/swagger-codegen/src/test/resources/2_0/petstore.yaml
Command line used for generation
java -jar swagger-codegen-cli.jar generate -i /api/swagger.yml -l php-symfony -o /src
Steps to reproduce
Any generated php-symfony code is invalid now and will fail should any exception be thrown.
- Generate any php-symfony code from any swagger configuration
- Throw an exception anywhere during the business logic execution.
Related issues/PRs
Issue introduced in: #6842
Related PR (removal of BaseController inheritance): #6615
Suggest a fix/enhancement
Fixed in #8338