Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASP.Net Core generate - .NET Core 3 / Swashbuckle 5 Support #9781

Closed
knom opened this issue Oct 14, 2019 · 9 comments
Closed

ASP.Net Core generate - .NET Core 3 / Swashbuckle 5 Support #9781

knom opened this issue Oct 14, 2019 · 9 comments
Assignees

Comments

@knom
Copy link
Contributor

knom commented Oct 14, 2019

Description
Update ASPNET Core generator to support .NET Core 3.0

Swagger-codegen version
2.0 branch

Suggest a fix/enhancement
Update ASPNET Core generator to support .NET Core 3.0

@gfrung4
Copy link

gfrung4 commented Dec 4, 2019

.NET Core 2.2 end of support is December 23, 2019. It would be nice to have support for .NET Core 3.0 soon. Is there any update on this?

It would also be nice to have support for .NET Core 3 added to the 3.0.0 branch for OpenAPI version 3.

@christiandersen
Copy link

I agree.

@knom
Copy link
Contributor Author

knom commented Dec 12, 2019

@frantuma please approve and merge!

@knom
Copy link
Contributor Author

knom commented Dec 12, 2019

Hmm.. I really liked the project - and did a few contributions every now and then..
(especially in combination w. https://editor.swagger.io)

But the community has changed, @wing328 is gone it seems..
Not sure how active / alive the codegen still is.. looking at alternatives right now!

Trying https://github.com/OpenAPITools/openapi-generator..

@frantuma frantuma modified the milestone: M1 Apr 20, 2020
@HugoMario
Copy link
Contributor

PR was merged and it's also been covered on v2 and v3, so closing this.

@bradygaster
Copy link
Contributor

@HugoMario - do you have a link to a v3 issue or pull request related to @knom's request? I work on the .NET team at Microsoft and would very much like to see an ASP.NET Core 3.1 server stub generator created. I'd be willing to submit a pull request to make it happen - is there any other ongoing work in this space, or is there a pre-existing 3.1 generator in the works?

Thanks in advance. Trust me - there is still very much interest in the OAS/Swagger opportunities for ASP.NET Core developers, and I'd be willing to work with the group to make this happen if we could get a little support in authoring the generators.

@HugoMario
Copy link
Contributor

Hi @bradygaster, this PR swagger-api/swagger-codegen-generators#642 is related to knom request for v3, it currently generates a aspnetcore version 3.0. Version 3.1 is in our path but with no ETA yet. So yea, it's pretty awesome receive any help to accomplish that.

Please, ping me if you need help with something.

@bradygaster
Copy link
Contributor

@HugoMario - I submitted a PR last night to make a slight improvement - #10216 - which repairs one small bug I saw in the 3.0 template. I'm going to start working on the 3.1 update ASAP, so if anyone has tips on how to best submit a PR, feedback/guidance is welcome.

@HugoMario
Copy link
Contributor

@bradygaster, here is a guide that you can use https://github.com/swagger-api/swagger-codegen/blob/master/CONTRIBUTING.md.

if you have any doubt or need help to merge PR, please dont hesitate to ping me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants