Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issued with TermsOfService #10216

Merged
merged 1 commit into from
May 1, 2020
Merged

fixed issued with TermsOfService #10216

merged 1 commit into from
May 1, 2020

Conversation

bradygaster
Copy link
Contributor

@bradygaster bradygaster commented Apr 30, 2020

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

This PR resolves issue #10215 and has been tested per the issue's description and supposed resolution. Thanks for the opportunity to serve the ASP.NET Core community by making this and out-of-the-box working experience with the most minimal set of arguments.

Copying @mandrean, as @mandrean is mentioned as the maintainer of the C# generators. The ASP.NET Core generator's owner isn't specifically mentioned, so if you're looking for one, I'd be willing to own it.

@HugoMario
Copy link
Contributor

great! thanks @bradygaster

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants