java jax rs code generation fix and formatting tidy #1093
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dme-path-fix Fix path in instructions for making your own codegen modules
This was referenced Aug 20, 2015
|
see https://github.com/swagger-api/swagger-codegen/pull/859/files#r37515455 for the introduction of the bug |
|
@ahgittin thanks! will review and let you know if I've any questions. |
|
@wing328 noticed the generated code did not compile in some cases due to |
ahgittin
force-pushed
the
jax-rs-format-fixes
branch
from
c3f5992 to
ac6a051
Compare
|
@ahgittin under Is this PR supposed to address that or the error is already there before you submitted the fix ? |
|
@ahgittin - due to a development procedure change, you'll have to resubmit the PR against the |
… `Impl` weren't written in eca8276 when `skipOverwrite` was introduced, a file exists check was moved into `DefaultCodegen.shouldOverwrite` effectively changing its semantics from "is overwriting allowed for this file" to "should we write this file". the method is overridden in `JaxRSServerCodegen` to specify that `Factory` and `Impl` files should always return false, because we never want to *overwrite* them. but the above change in semantics meant we would never *write* these files. this reverts the semantics of that method, in line with both the method name and the jax-rs interpretation, and introduces a new `shouldSkipOverwrite` which adds the file exists check and is used in places where the above commit expected the latter semantics.
alignment and line spaces were odd and inconsistent; this tries to respect the coding conventions which it seems were intended, but make them consistent (i'm not trying to bike-shed how code should be formatted, honest, just to make the formatting which it seems was intended line up!)
ahgittin
force-pushed
the
jax-rs-format-fixes
branch
from
ac6a051 to
0fc2532
Compare
|
@wing328 I've rebased on master and will submit PR shortly. I've no idea why that error appeared, it is supposed to build, and when I do this (after the rebase and tidies) all works well: |
|
Closing in preference to #1119 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduction of
skipOverwritein #831 / #859 causedFactoryandImplclasses never to be written for jax-rs. this fixes that.also i noticed the old jax-rs templates have bad spacing, e.g.
this aligns things and generally improves whitespace (superseding #1092 as per @wing328 's comment)